Bluemindo
Tracker Bug tracking
» Click here to report a bug on this project.
| Bug report #531 | |||
| Title: | tagpy & soundjuicer bug affects bluemindo | ||
| Date added: | 2009-02-17 18:17:48 | Type: | Bug report |
| Status: | Rejected | Priority: | Normal |
| Affected version: | trunk | Milestone: | n/a |
| Reported by: | strider | Assigned to: | xbright |
| History: | Attachements: |
|
|
|
Sound Juicer 2.24 produce ogg vorbis with a oga extension, but as Xiph.org recommends, oga extension is for Ogg Flac (and some other stuff).
tagpy doesn't handle this as it thinks that an oga extension means a flac file. I've modified musicdb.py so that is checks that the oga file is a Vorbis or not and if so, it renames it into .ogg diff musicdb.orig.py musicdb.py 22c22 < from os import walk --- > from os import walk,rename 56a57,58 > if file_.endswith("oga"): > filename = self.checkoga(filename) 137a140,149 > > def checkoga(self,filename): > ogafile = open(filename,'r') > header = ogafile.read(100) > newfilename = filename > if "vorbis" in header: > newfilename = filename[0:len(filename)-1] + "g" > rename(filename, newfilename) > ogafile.close() > return newfilename |
|||
| Re: tagpy & soundjuicer bug affects bluemindo - 2009-02-17 20:11:05 | |
 xbright    |
Hm.
As it stands in the Xiph.org wiki, .oga “Covers Ogg FLAC, Ghost, and OggPCM”. If Sound Juicer puts Ogg Vorbis inside .oga it's a Sound Juicer bug, not a Bluemindo one. You really should report a bug to Sound Juicer instead of propose this patch doomed to failure. |
| This bug is closed. |
